Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp: move gpref from buildInputs to nativeBuildInputs #96745

Merged
merged 1 commit into from
Aug 31, 2020
Merged

libseccomp: move gpref from buildInputs to nativeBuildInputs #96745

merged 1 commit into from
Aug 31, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Aug 31, 2020

Fixes a cross-compilation issue due to gperf not being available on the host system

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Aug 31, 2020

@GrahamcOfBorg build libseccomp
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.libseccomp

@ofborg ofborg bot requested a review from thoughtpolice August 31, 2020 10:07
@kampka kampka added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Aug 31, 2020
FRidh
FRidh requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeWrapper should be removed as it is unused (otherwise it would have had to be moved as well)

@kampka
Copy link
Contributor Author

kampka commented Aug 31, 2020

makeWrapper should be removed as it is unused (otherwise it would have had to be moved as well)

Done

@kampka kampka requested a review from FRidh August 31, 2020 15:35
@FRidh FRidh merged commit 0730d80 into NixOS:staging Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kampka @FRidh